You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2016/11/18 21:52:30 UTC
[4/6] wicket git commit: Minor non-functional cleanup:
Minor non-functional cleanup:
- remove implicit modifiers
- update comments
- remove empty lines
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/fa7cf4fd
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/fa7cf4fd
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/fa7cf4fd
Branch: refs/heads/master
Commit: fa7cf4fd48c2d73f056be2881ca169ee3790165e
Parents: 4c31e16
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Fri Nov 18 22:45:09 2016 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Fri Nov 18 22:45:09 2016 +0100
----------------------------------------------------------------------
.../java/org/apache/wicket/cdi/ConversationalComponent.java | 1 -
.../java/org/apache/wicket/cdi/IConversationPropagation.java | 2 +-
.../java/org/apache/wicket/cdi/IConversationPropagation.java | 4 ++--
wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java | 7 -------
.../src/main/java/org/apache/wicket/css/ICssCompressor.java | 1 -
.../src/main/java/org/apache/wicket/page/IManageablePage.java | 5 +----
.../wicket/request/resource/IResourceReferenceFactory.java | 2 +-
.../org/apache/wicket/resource/IPropertiesChangeListener.java | 2 +-
.../org/apache/wicket/response/filter/IResponseFilter.java | 2 +-
.../extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java | 2 +-
.../wicket/extensions/markup/html/basic/ILinkParser.java | 2 +-
.../extensions/markup/html/form/select/IOptionRenderer.java | 4 ++--
.../extensions/markup/html/repeater/data/sort/ISortState.java | 4 ++--
.../apache/wicket/extensions/wizard/IWizardModelListener.java | 2 +-
14 files changed, 14 insertions(+), 26 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/ConversationalComponent.java
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/ConversationalComponent.java b/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/ConversationalComponent.java
index 0c8875d..16d9fc1 100644
--- a/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/ConversationalComponent.java
+++ b/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/ConversationalComponent.java
@@ -27,5 +27,4 @@ package org.apache.wicket.cdi;
*/
public interface ConversationalComponent
{
-
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
----------------------------------------------------------------------
diff --git a/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java b/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
index 6b3d286..b9eb1e3 100644
--- a/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
+++ b/wicket-cdi-1.1/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
@@ -43,5 +43,5 @@ public interface IConversationPropagation
* @return true if the conversation should be propagated for the given
* request handler.
*/
- public boolean propagatesVia(IRequestHandler handler, Page page);
+ boolean propagatesVia(IRequestHandler handler, Page page);
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-cdi/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
----------------------------------------------------------------------
diff --git a/wicket-cdi/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java b/wicket-cdi/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
index 154b077..f2086a8 100644
--- a/wicket-cdi/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
+++ b/wicket-cdi/src/main/java/org/apache/wicket/cdi/IConversationPropagation.java
@@ -37,7 +37,7 @@ public interface IConversationPropagation
* The current request handler
* @return true if the conversation should be propagated to the given page instance.
*/
- public boolean propagatesViaPage(Page page, IRequestHandler handler);
+ boolean propagatesViaPage(Page page, IRequestHandler handler);
/**
* Indicates if the conversation should be propagated via url-parameters for the given request
@@ -47,5 +47,5 @@ public interface IConversationPropagation
* The current request handler
* @return true if the conversation should be propagated for the given request handler.
*/
- public boolean propagatesViaParameters(IRequestHandler handler);
+ boolean propagatesViaParameters(IRequestHandler handler);
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java b/wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java
index de72153..b6ef154 100644
--- a/wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java
+++ b/wicket-core/src/main/java/org/apache/wicket/IQueueRegion.java
@@ -33,13 +33,6 @@ import org.apache.wicket.markup.IMarkupFragment;
*/
public interface IQueueRegion
{
- /**
- * TODO Wicket 8: this interface might be a perfect candidate for Java 8 interface default methods.
- * Now methods implementation is in MarkupContainer while it should simply be in those
- * classes which implement this interface.
- *
- * */
-
/**
* Creates a new {@link DequeueContext} that will be used to dequeue children of this region.
*
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/css/ICssCompressor.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/css/ICssCompressor.java b/wicket-core/src/main/java/org/apache/wicket/css/ICssCompressor.java
index c9e8da9..cb77c12 100644
--- a/wicket-core/src/main/java/org/apache/wicket/css/ICssCompressor.java
+++ b/wicket-core/src/main/java/org/apache/wicket/css/ICssCompressor.java
@@ -23,5 +23,4 @@ import org.apache.wicket.resource.ITextResourceCompressor;
*/
public interface ICssCompressor extends ITextResourceCompressor
{
-
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java b/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
index 8e9d86b..11c3756 100644
--- a/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
+++ b/wicket-core/src/main/java/org/apache/wicket/page/IManageablePage.java
@@ -18,10 +18,7 @@ package org.apache.wicket.page;
import org.apache.wicket.util.io.IClusterable;
-// TODO WICKET-NG: this iface used to extend IDetachable, however this causes problems because Page becomes IDetachable and some property models will cause an infinite loop triggering detach on the component again because it is their target object. In the future Component should indeed implement IDetachable, for now copied #detach into this iface directly.
-/**
- * TODO javadoc
- */
+// this iface used to extend IDetachable, however this causes problems because Page becomes IDetachable and some property models will cause an infinite loop triggering detach on the component again because it is their target object. In the future Component should indeed implement IDetachable, for now copied #detach into this iface directly.
public interface IManageablePage extends IClusterable
{
/**
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/request/resource/IResourceReferenceFactory.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/request/resource/IResourceReferenceFactory.java b/wicket-core/src/main/java/org/apache/wicket/request/resource/IResourceReferenceFactory.java
index 9b15f8c..6084f16 100644
--- a/wicket-core/src/main/java/org/apache/wicket/request/resource/IResourceReferenceFactory.java
+++ b/wicket-core/src/main/java/org/apache/wicket/request/resource/IResourceReferenceFactory.java
@@ -32,4 +32,4 @@ public interface IResourceReferenceFactory
* such with the given request attributes
*/
ResourceReference create(ResourceReference.Key key);
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/resource/IPropertiesChangeListener.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/resource/IPropertiesChangeListener.java b/wicket-core/src/main/java/org/apache/wicket/resource/IPropertiesChangeListener.java
index 69e569d..d503e7b 100644
--- a/wicket-core/src/main/java/org/apache/wicket/resource/IPropertiesChangeListener.java
+++ b/wicket-core/src/main/java/org/apache/wicket/resource/IPropertiesChangeListener.java
@@ -31,4 +31,4 @@ public interface IPropertiesChangeListener
* @param key
*/
void propertiesChanged(final String key);
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-core/src/main/java/org/apache/wicket/response/filter/IResponseFilter.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/response/filter/IResponseFilter.java b/wicket-core/src/main/java/org/apache/wicket/response/filter/IResponseFilter.java
index 89b0ce3..92fb1e4 100644
--- a/wicket-core/src/main/java/org/apache/wicket/response/filter/IResponseFilter.java
+++ b/wicket-core/src/main/java/org/apache/wicket/response/filter/IResponseFilter.java
@@ -44,4 +44,4 @@ public interface IResponseFilter
* @return The changed buffer or the response buffer itself (changed or not)
*/
AppendingStringBuffer filter(AppendingStringBuffer responseBuffer);
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java
index 442e1e0..e6142a8 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/breadcrumb/panel/IBreadCrumbPanelFactory.java
@@ -39,4 +39,4 @@ public interface IBreadCrumbPanelFactory extends IClusterable
* @return A new bread crumb panel instance
*/
BreadCrumbPanel create(String componentId, IBreadCrumbModel breadCrumbModel);
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/ILinkParser.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/ILinkParser.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/ILinkParser.java
index 40e2dae..fbd9f79 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/ILinkParser.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/basic/ILinkParser.java
@@ -34,4 +34,4 @@ public interface ILinkParser
* @return the modified input text.
*/
String parse(String text);
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/IOptionRenderer.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/IOptionRenderer.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/IOptionRenderer.java
index 3103924..e641c57 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/IOptionRenderer.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/IOptionRenderer.java
@@ -34,7 +34,7 @@ public interface IOptionRenderer<T> extends IClusterable
* SelectOption model object
* @return the value for displaying to the user.
*/
- public String getDisplayValue(T object);
+ String getDisplayValue(T object);
/**
* Gets the model that will be used to represent the value object.
@@ -44,5 +44,5 @@ public interface IOptionRenderer<T> extends IClusterable
* @param value
* @return model that will contain the value object
*/
- public IModel<T> getModel(T value);
+ IModel<T> getModel(T value);
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/sort/ISortState.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/sort/ISortState.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/sort/ISortState.java
index 0bf868e..c3126af 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/sort/ISortState.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/sort/ISortState.java
@@ -36,7 +36,7 @@ public interface ISortState<S> extends IClusterable
* @param order
* sort order
*/
- public void setPropertySortOrder(S property, SortOrder order);
+ void setPropertySortOrder(S property, SortOrder order);
/**
* Gets the sort order of a property
@@ -45,6 +45,6 @@ public interface ISortState<S> extends IClusterable
* sort property to be checked
* @return sort order
*/
- public SortOrder getPropertySortOrder(S property);
+ SortOrder getPropertySortOrder(S property);
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/fa7cf4fd/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModelListener.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModelListener.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModelListener.java
index c8d676f..2331ae5 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModelListener.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModelListener.java
@@ -19,7 +19,7 @@ package org.apache.wicket.extensions.wizard;
import org.apache.wicket.util.io.IClusterable;
/**
- * Recieves notifications for wizard model state changes.
+ * Receives notifications for wizard model state changes.
*
* @author Eelco Hillenius
*/