You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/24 11:10:02 UTC
[GitHub] [ozone] bshashikant opened a new pull request #2362: HDDS-5381. SCM terminated with exit status 1: null.
bshashikant opened a new pull request #2362:
URL: https://github.com/apache/ozone/pull/2362
## What changes were proposed in this pull request?
Ensure getPipeline() is called inside write lock()
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5381
## How was this patch tested?
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2362: HDDS-5381. SCM terminated with exit status 1: null.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2362:
URL: https://github.com/apache/ozone/pull/2362#discussion_r657854503
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerV2Impl.java
##########
@@ -248,8 +248,8 @@ public void updatePipelineState(
PipelineID pipelineID = PipelineID.getFromProtobuf(pipelineIDProto);
Pipeline.PipelineState oldState = null;
try {
- oldState = getPipeline(pipelineID).getPipelineState();
lock.writeLock().lock();
Review comment:
Move the lock outside try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #2362: HDDS-5381. SCM terminated with exit status 1: null.
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #2362:
URL: https://github.com/apache/ozone/pull/2362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org