[jira] [Commented] (LENS-50) Checkstyle related changes on lens-cube

["Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LENS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221648#comment-14221648 ] 

Amareshwari Sriramadasu commented on LENS-50:
---------------------------------------------

Thanks [~prongs] for putting the patch.

Some comments :
* Making constants in MetastoreConstants to package private is not harmful. But i think we are using the constants in other modules as well. We might have to add getter methods.
* interface PartitionMetahook will be public interface, sothat implementations can be in another module

Other changes look fine. I didn't look at test changes in detail, hoping they are all only style changes and no code changes.

I'm fine doing the remaining style changes in a different jira.


> Checkstyle related changes on lens-cube
> ---------------------------------------
>
>                 Key: LENS-50
>                 URL: https://issues.apache.org/jira/browse/LENS-50
>             Project: Apache Lens
>          Issue Type: Sub-task
>          Components: cube
>    Affects Versions: 2.0
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>             Fix For: 2.0
>
>         Attachments: LENS-50.0.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)