You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/12 04:16:32 UTC
[GitHub] [cordova-ios] erisu commented on a change in pull request #886: Add PreferredContentMode preference
erisu commented on a change in pull request #886:
URL: https://github.com/apache/cordova-ios/pull/886#discussion_r439197924
##########
File path: CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
##########
@@ -135,6 +135,16 @@ - (WKWebViewConfiguration*) createConfigurationFromSettings:(NSDictionary*)setti
}
configuration.applicationNameForUserAgent = userAgent;
+ if (@available(iOS 13.0, *)) {
+ NSString *contentMode = [settings cordovaSettingForKey:@"PreferredContentMode"];
+ if ([contentMode isEqual: @"mobile"]) {
Review comment:
```suggestion
if ([contentMode isEqual: @"mobile"]) {
```
Removed double spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org