You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/13 05:58:54 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1835: test: DNS cache expires, re-parse the host of the upstream node by DN…
membphis opened a new pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835
…S and proxy
the request to the new address.
We have fixed this bug in `master` branch, but we can get if we run this test case in branch `v1.4`.
Add some test cases to confirm the `master` branch works fine for this case.
```
# 1.4 version
t/node/upstream-node-dns.t .. 7/?
# Failed test 'TEST 3: dns cached expired, reparse the domain in upstream node - grep_error_log_out (req 0)'
# at /usr/local/share/perl5/5.30/Test/Nginx/Socket.pm line 1088.
# @@ -1,10 +1,14 @@
# call /hello
# dns resolver domain: test.com to 127.0.0.1
# proxy to 127.0.0.1:1980
# +proxy to 127.0.0.1:1980
# call /hello
# dns resolver domain: test.com to 127.0.0.2
# -proxy to 127.0.0.2:1980
# -proxy to 127.0.0.2:1980
# +proxy to 127.0.0.1:1980
# +proxy to 127.0.0.1:1980
# +proxy to 127.0.0.1:1980
# +proxy to 127.0.0.1:1980
# call /hello
# dns resolver domain: test.com to 127.0.0.3
# -proxy to 127.0.0.3:1980
# +proxy to 127.0.0.1:1980
# +proxy to 127.0.0.1:1980
# Looks like you failed 1 test of 8.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835#issuecomment-658090574
> got it. It will be great if you can give some detail about those bugs, like when it will trigger, which users it will affect, etc.
Haha, I am happy to write more about this bug. I'm sorry to write more information so late.
here is the step:
1. check upstream if the upstream node contains a domain
2. parse the upstream node by DNS server
3. reuse upstream node first resolved by DNS, and never update <- bug
If we put the upstream node to route, it'll trigger this bug.
If we put the upstream node to upstream object, it'll trigger this bug.
We need to use the latest upstream node resolved by the DNS server always.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835#issuecomment-657948849
> While adding test cases, two new bugs were found, and those bugs have existed for several months.
got it. It will be great if you can give some detail about those bugs, like when it will trigger, which users it will affect, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835#issuecomment-657940337
> We have fixed this bug in `master` branch, but we can get if we run this test case in branch `v1.4`.
> Add some test cases to confirm the `master` branch works fine for this case.
Is this a bugfix PR or only add test cases? Please describe it more clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835#issuecomment-657945389
While adding test cases, two new bugs were found, and those bugs have existed for several months.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] nic-chen commented on pull request #1835: bugfix: fetch wrong the upstream node when there were multiple upstream node with host
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1835:
URL: https://github.com/apache/incubator-apisix/pull/1835#issuecomment-660097344
LGTM.
But i think it's hard to test for DNS update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org