You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by zzcoder <gi...@git.apache.org> on 2015/06/24 20:03:41 UTC
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
GitHub user zzcoder opened a pull request:
https://github.com/apache/curator/pull/85
CURATOR-225: Added new ErrorMode value KEEP.
Added ErrorMode.KEEP. Created a new test-case testKeepMode() to make sure it works.
If the new mode is not used, the code should work as is so the impact of this change is very limited.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zzcoder/curator master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 035eefc316d84093be9090ceff15d4ac8a90fcdc
Author: Zhihong Zhang <zh...@pixia.com>
Date: 2015-06-24T17:55:59Z
CURATOR-225: Added new ErrorMode value KEEP.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-122707775
Hi zzcoder! Thank you for your contribution and especially for including a test. I'm a little confused about how this behaviour is supposed to differ from `REQUEUE`. Can you please clarify the intent for me? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by zzcoder <gi...@git.apache.org>.
Github user zzcoder closed the pull request at:
https://github.com/apache/curator/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by zzcoder <gi...@git.apache.org>.
Github user zzcoder commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-122711814
@Randgalt I thought about that and it's problematic. The queue uses SEQUENTIAL flag. The sequence number determines the order in the queue. It seems that you have to tamper with ZooKeeper to achieve that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-202646917
@zzcoder any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by zzcoder <gi...@git.apache.org>.
Github user zzcoder commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-202908099
This PULL request is not needed anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-122711932
For the requeue, the sequence number has already been used so a simple create with the same sequence number would work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by zzcoder <gi...@git.apache.org>.
Github user zzcoder commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-122711667
@madrob With REQUEUE, the entry is removed from the queue and appended to the back of the queue, it violates the FIFO principal of the queue and it matters to our application. With the added option, the item will be kept in the queue intact.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: CURATOR-225: Added new ErrorMode value KEEP.
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/85#issuecomment-122711711
Maybe we should have REQUEUE attempt to put it back where it was instead of adding a new mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---