You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/14 03:31:06 UTC
[GitHub] [rocketmq] ShannonDing opened a new pull request #2600: [ISSUE #2576] update NOTICE and fix typo in license
ShannonDing opened a new pull request #2600:
URL: https://github.com/apache/rocketmq/pull/2600
**Make sure set the target branch to `develop`**
## What is the purpose of the change
fix #2576
update NOTICE and fix typo in license
## Brief changelog
1)update NOTICE year to 2021
2)fix typo in license
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2600: [ISSUE #2576] update NOTICE and fix typo in license
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2600:
URL: https://github.com/apache/rocketmq/pull/2600#issuecomment-759909933
[](https://coveralls.io/builds/36313765)
Coverage increased (+0.2%) to 52.01% when pulling **a1df9b54d69653352e017d0b57f17669fe77a72e on ShannonDing:license_update** into **79ed2b6f894ca2655d9b4b23bee141dc635d8d0a on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #2600: [ISSUE #2576] update NOTICE and fix typo in license
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #2600:
URL: https://github.com/apache/rocketmq/pull/2600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on pull request #2600: [ISSUE #2576] update NOTICE and fix typo in license
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2600:
URL: https://github.com/apache/rocketmq/pull/2600#issuecomment-759991520
Good job ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org