You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/21 03:22:15 UTC

[GitHub] [rocketmq] caigy commented on a change in pull request #2961: [ISSUE #2883] [Part F] Improve produce performance in M/S mode.

caigy commented on a change in pull request #2961:
URL: https://github.com/apache/rocketmq/pull/2961#discussion_r673631974



##########
File path: common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java
##########
@@ -409,7 +409,20 @@ public static MessageExt decode(
     }
 
     public static String messageProperties2String(Map<String, String> properties) {
-        StringBuilder sb = new StringBuilder();
+        int len = 0;

Review comment:
       Extract a method for calculating size




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org