You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@continuum.apache.org by "Marecor M. Baclay (JIRA)" <ji...@codehaus.org> on 2010/06/02 05:08:12 UTC
[jira] Created: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Editing Build Definition doesn't reflect changes when saved
-----------------------------------------------------------
Key: CONTINUUM-2532
URL: http://jira.codehaus.org/browse/CONTINUUM-2532
Project: Continuum
Issue Type: Bug
Affects Versions: 1.4.0 (Beta)
Reporter: Marecor M. Baclay
Steps to replicate:
1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
2. Build definitions page is shown with new entry. Click on edit.
3. Set "Always Build" to FALSE and click save.
4. Build definitions page is shown but the value is still TRUE
5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Jevica Arianne B. Zurbano (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223862#action_223862 ]
Jevica Arianne B. Zurbano commented on CONTINUUM-2532:
------------------------------------------------------
Hi Catherine,
IIRC, "Always Build" executes the project build even if there are no changes to the project which I think is used during scheduled builds.
And, "Build Fresh" checks out a copy of the project whenever the build is triggered.
So I think it is possible to set "Build Fresh" to TRUE and "Always Build" to FALSE.
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (CONTINUUM-2532) Editing Build
Definition doesn't reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223998#action_223998 ]
Maria Catherine Tan edited comment on CONTINUUM-2532 at 6/3/10 6:16 PM:
------------------------------------------------------------------------
Yes, but if it's a build fresh, Continuum "always build" the project even if it's a scheduled build.
IMO, saying that you want to have a build fresh but not build it will just cause confusion. The user might wonder why the project build when they set always build to false.
FYI, Continuum first checks the BUILD FRESH before it checks the ALWAYS BUILD.
was (Author: ctan):
Yes, but if it's a build fresh it "always build" even if it's a scheduled build.
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223857#action_223857 ]
Maria Catherine Tan commented on CONTINUUM-2532:
------------------------------------------------
If Build Fresh is true, it means it will always build. So having a build fresh set to true and always build to false is confusing.
I think if Build Fresh is true, the always build should be set to true and disabled.
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223999#action_223999 ]
Maria Catherine Tan commented on CONTINUUM-2532:
------------------------------------------------
You're correct that "Build Fresh" will remove the directory and checks out a new copy of the project whenever the build is triggered.
But Continuum will also check "Build Fresh" when trying to determine if project should build or not.
See DefaultBuildController#shouldBuild
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Catherine Tan reassigned CONTINUUM-2532:
----------------------------------------------
Assignee: Maria Catherine Tan
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maria Catherine Tan closed CONTINUUM-2532.
------------------------------------------
Resolution: Fixed
Fix Version/s: 1.4.1 (Beta)
Fixed in r951289
- set 'Always Build' to true and disable it when 'Build Fresh' is checked
- set 'Always Build' to false and enable it when 'Build Fresh' is unchecked
- document that checking 'Build Fresh' will always build the project
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
> Fix For: 1.4.1 (Beta)
>
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224013#action_224013 ]
Maria Catherine Tan commented on CONTINUUM-2532:
------------------------------------------------
Yes! I'll do that in this fix.
Thanks Jev!
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Jevica Arianne B. Zurbano (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224011#action_224011 ]
Jevica Arianne B. Zurbano commented on CONTINUUM-2532:
------------------------------------------------------
Thanks for clarifying, Catherine.
Probably the behavior needs to be documented, wdyt?
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CONTINUUM-2532) Editing Build Definition doesn't
reflect changes when saved
Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/CONTINUUM-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223998#action_223998 ]
Maria Catherine Tan commented on CONTINUUM-2532:
------------------------------------------------
Yes, but if it's a build fresh it "always build" even if it's a scheduled build.
> Editing Build Definition doesn't reflect changes when saved
> -----------------------------------------------------------
>
> Key: CONTINUUM-2532
> URL: http://jira.codehaus.org/browse/CONTINUUM-2532
> Project: Continuum
> Issue Type: Bug
> Affects Versions: 1.4.0 (Beta)
> Reporter: Marecor M. Baclay
> Assignee: Maria Catherine Tan
>
> Steps to replicate:
> 1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
> 2. Build definitions page is shown with new entry. Click on edit.
> 3. Set "Always Build" to FALSE and click save.
> 4. Build definitions page is shown but the value is still TRUE
> 5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
> 6. Build definitions page is shown with both values now FALSE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira