You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/20 15:42:27 UTC

[GitHub] [tvm] mikepapadim opened a new pull request #9050: [hot-fix][CI]Disable mypy for ethosu

mikepapadim opened a new pull request #9050:
URL: https://github.com/apache/tvm/pull/9050


   Fix for failing CI on ethosu mypy sanity checks
   
   @tqchen @mehrdadh 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923047846


   cc @manupa-arm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923408589


   this hit #9013, we also need to fix that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923078778


   Thanks for catching this! Any idea why it did not fail before?
   
   cc: @mbaret @ashutosh-arm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mikepapadim commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923762856


   @areusch I think this PR can be closed if #9052 get through.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mikepapadim commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923082147


   @manupa-arm it looks like the changes causing this one are from here https://github.com/apache/tvm/pull/8806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923411445


   Can we set up a big red button that merges something without CI passing? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] manupa-arm commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923085528


   Thanks @mikepapadim!  but I believe it passed CI with those checks. Did anything change on the CI ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mikepapadim commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923762446


   > this hit #9013, we also need to fix that.
   
   This bug hits also stagging Jenkins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-924415673


   i dont think committers have permission to merge a pr without CI green. maybe it's a merge conflict? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] ashutosh-arm commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923092912


   Ignoring missing stub warnings can be fixed with this:
   
    mypy  --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/ --ignore-missing-imports 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] ashutosh-arm edited a comment on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
ashutosh-arm edited a comment on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-923092912


   Missing stub warnings can be fixed with this:
   
    mypy  --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/ --ignore-missing-imports 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9050:
URL: https://github.com/apache/tvm/pull/9050#issuecomment-924495634


   i think we don't need this anymore. closing, feel free to reopen if we do need it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch closed pull request #9050: [hot-fix][CI]Disable mypy for ethosu

Posted by GitBox <gi...@apache.org>.
areusch closed pull request #9050:
URL: https://github.com/apache/tvm/pull/9050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org