You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2026/04/15 03:24:23 UTC
[PR] [fix][ci] Ensure discard_max_bytes is set to 0 only for existing block devices [bookkeeper]
nodece opened a new pull request, #4745:
URL: https://github.com/apache/bookkeeper/pull/4745
### Motivation
In CI environments, the following error was observed when attempting to disable discard:
```
tee: '/sys/block/sd*/queue/discard_max_bytes': No such file or directory
Error: Process completed with exit code 1.
```
This happens because the script assumes block devices follow the `sd*` naming convention, which is not always true (e.g., NVMe or virtual disks). As a result, the glob does not match any files and causes the step to fail.
### Modifications
* Replace `/sys/block/sd*/queue/discard_max_bytes` with `/sys/block/*/queue/discard_max_bytes` to support all block device types
* Add a file existence check (`-f`) before applying `tee` to avoid errors when the file is not present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: ensure discard_max_bytes is set to 0 only for existing block devices [bookkeeper]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #4745:
URL: https://github.com/apache/bookkeeper/pull/4745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org