You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Rohit Koushal (JIRA)" <ji...@apache.org> on 2016/08/27 08:14:21 UTC

[jira] [Updated] (OFBIZ-7982) Enforce noninstantiability to ICalWorker class

     [ https://issues.apache.org/jira/browse/OFBIZ-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohit Koushal updated OFBIZ-7982:
---------------------------------
    Attachment: OFBIZ-7982.patch

Thanks [~rishisolankii] for the details.  Here is the patch for the issue.

> Enforce noninstantiability to ICalWorker class
> ----------------------------------------------
>
>                 Key: OFBIZ-7982
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7982
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: workeffort
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>            Assignee: Rohit Koushal
>            Priority: Minor
>         Attachments: OFBIZ-7982.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make following protected static methods as private;
> {code}
>     - protected static Map<String, Object> createConversionContext(HttpServletRequest request)
>     - protected static Date getLastModifiedDate(HttpServletRequest request) throws GenericEntityException
>     - protected static boolean isValidRequest(HttpServletRequest request, HttpServletResponse response) throws IOException 
>     - protected static void logInUser(HttpServletRequest request, HttpServletResponse response) throws GenericServiceException, GenericEntityException
>     - protected static void setupRequest(HttpServletRequest request, HttpServletResponse response)
>     - protected static void writeResponse(ResponseProperties responseProps, HttpServletRequest request, HttpServletResponse response, ServletContext context) throws IOException
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)