You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/10 10:19:02 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #5422: [Improvement][api] optimize api controller with AuthUtil

ruanwenjun commented on pull request #5422:
URL: https://github.com/apache/dolphinscheduler/pull/5422#issuecomment-836517279


   Sorry, I think that if this pr just reduce the declared `loginUser` parameter in the controller, it doesn't make much sense, because the `loginUser` parameter still needs to be passed between multiple methods after modification.
   
   If you want to reduce parameter passing, I would accept to use this implementation to achieve. https://www.programmersought.com/article/93593446439/
   
   It is my personal opinion and does not represent the community, just for reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org