You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/12/14 01:19:59 UTC

[GitHub] [druid] jon-wei commented on a change in pull request #12057: Document query context parameters related to join filters

jon-wei commented on a change in pull request #12057:
URL: https://github.com/apache/druid/pull/12057#discussion_r768244121



##########
File path: docs/querying/query-context.md
##########
@@ -79,6 +79,15 @@ In addition, some query types offer context parameters specific to that query ty
 |-----------------|---------------------|----------------------|
 |skipEmptyBuckets | `false`             | Disable timeseries zero-filling behavior, so only buckets with results will be returned. |
 
+### Join filter
+
+|property         |default              | description          |
+|-----------------|---------------------|----------------------|
+|enableJoinFilterPushDown | `true` | Controls whether a join query will attempt filter push down, which reduces the number of rows that have to be compared in a join operation.|
+|enableJoinFilterRewrite | `false` | Controls whether filter clauses that reference non-base table columns will be rewritten into filters on base table columns.|

Review comment:
       `enableJoinFilterRewrite` defaults to `true` now

##########
File path: docs/querying/query-context.md
##########
@@ -79,6 +79,15 @@ In addition, some query types offer context parameters specific to that query ty
 |-----------------|---------------------|----------------------|
 |skipEmptyBuckets | `false`             | Disable timeseries zero-filling behavior, so only buckets with results will be returned. |
 
+### Join filter
+
+|property         |default              | description          |
+|-----------------|---------------------|----------------------|
+|enableJoinFilterPushDown | `true` | Controls whether a join query will attempt filter push down, which reduces the number of rows that have to be compared in a join operation.|
+|enableJoinFilterRewrite | `false` | Controls whether filter clauses that reference non-base table columns will be rewritten into filters on base table columns.|
+|enableJoinFilterRewriteValueColumnFilters | `false` | Controls whether Druid rewrites non-base table filters on non-key columns. Requires a scan of the non-base table.|

Review comment:
       Suggest "Controls whether Druid rewrites non-base table filters on non-key columns in the non-base table. Requires a scan of the non-base table."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org