You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Peter Firmstone (JIRA)" <ji...@apache.org> on 2009/09/24 22:58:16 UTC
[jira] Resolved: (RIVER-310) [patch] fix possible NPE due to
incorrectly ordered if guard
[ https://issues.apache.org/jira/browse/RIVER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Firmstone resolved RIVER-310.
-----------------------------------
Resolution: Fixed
Patches supplied checked & merged.
> [patch] fix possible NPE due to incorrectly ordered if guard
> ------------------------------------------------------------
>
> Key: RIVER-310
> URL: https://issues.apache.org/jira/browse/RIVER-310
> Project: River
> Issue Type: Improvement
> Environment: NA
> Reporter: Dave Brosius
> Assignee: Peter Firmstone
> Priority: Trivial
> Attachments: fix_possible_npe.diff
>
>
> Code improperly orders null length 0 guard, opening the possibility of a NPE
> patch fixes
> - if ((name.length() == 0) || (name == null)) {
> + if ((name == null) || (name.length() == 0)) {
> throw new IOException("no name specified in preference" +
> " expression");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.