You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "z3d1k (via GitHub)" <gi...@apache.org> on 2024/03/20 11:06:51 UTC
[PR] [FLINK-34892][ci] Fix python test failure due to config file change [flink-connector-aws]
z3d1k opened a new pull request, #133:
URL: https://github.com/apache/flink-connector-aws/pull/133
## Purpose of the change
Removing `pyflink_gateway_server.py` override after Flink 1.19.0 release to support configuration file change.
Override was initially introduced [here](https://github.com/apache/flink-connector-kafka/pull/69) and replicated for AWS connectors.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
Local test run
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34892][ci] Fix python test failure due to config file change [flink-connector-aws]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #133:
URL: https://github.com/apache/flink-connector-aws/pull/133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34892][ci] Fix python test failure due to config file change [flink-connector-aws]
Posted by "z3d1k (via GitHub)" <gi...@apache.org>.
z3d1k commented on code in PR #133:
URL: https://github.com/apache/flink-connector-aws/pull/133#discussion_r1531899935
##########
flink-python/dev/integration_test.sh:
##########
@@ -41,10 +41,5 @@ FLINK_PYTHON_DIR=$(dirname "$CURRENT_DIR")
# set the FLINK_TEST_LIB_DIR to "<root-project-folder>/flink-connector-aws/flink-python-connector-aws/target/dep..."
export FLINK_TEST_LIBS="${FLINK_PYTHON_DIR}/target/test-dependencies/*"
-# Temporarily update the installed 'pyflink_gateway_server.py' files with the new one
-# Needed only until Flink 1.19 release
-echo "Checking ${FLINK_PYTHON_DIR} for 'pyflink_gateway_server.py'"
-find "${FLINK_PYTHON_DIR}/.tox" -name pyflink_gateway_server.py -exec cp "${FLINK_PYTHON_DIR}/pyflink/pyflink_gateway_server.py" {} \;
Review Comment:
Removed to use `pyflink_gateway_server.py` provided by pyflink instead of local copy.
##########
flink-python/tox.ini:
##########
@@ -21,7 +21,7 @@
# in multiple virtualenvs. This configuration file will run the
# test suite on all supported python versions.
# new environments will be excluded by default unless explicitly added to envlist.
-envlist = {py37, py38, py39, py310}-cython
Review Comment:
The current fix does not work for python 3.7 because there is no 1.19 package released for this python version.
Since dependency on `apache-flink` python package is set as `apache-flink>=1.17.0` - only the latest available Flink version is used during testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34892][ci] Fix python test failure due to config file change [flink-connector-aws]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #133:
URL: https://github.com/apache/flink-connector-aws/pull/133#issuecomment-2010729129
Thanks @z3d1k. Waiting for actions to complete before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org