[GitHub] [spark] xkrogen commented on a change in pull request #35358: [SPARK-38062][CORE] Avoid resolving placeholder hostname for FallbackStorage in BlockManagerDecommissioner

[GitBox <gi...@apache.org>]

xkrogen commented on a change in pull request #35358:
URL: https://github.com/apache/spark/pull/35358#discussion_r802147108



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##########
@@ -131,7 +135,10 @@ private[storage] class BlockManagerDecommissioner(
                 // driver a no longer referenced RDD with shuffle files.
                 if (bm.migratableResolver.getMigrationBlocks(shuffleBlockInfo).size < blocks.size) {
                   logWarning(s"Skipping block $shuffleBlockInfo, block deleted.")
-                } else if (fallbackStorage.isDefined) {
+                } else if (fallbackStorage.isDefined
+                  // Confirm peer is not the fallback BM ID because then fallbackStorage would
+                  // already have been used in the try-block above and there's no point trying again
+                  && peer != FallbackStorage.FALLBACK_BLOCK_MANAGER_ID) {

Review comment:
       It looks correct to me. I also just tried running `./dev/scalafmt` and it used this indentation. Do you have another opinion on what it should be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org