You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2006/11/10 10:41:37 UTC
[jira] Created: (JAMES-684) testConnectionLimitExceeded junit test
is broken
testConnectionLimitExceeded junit test is broken
------------------------------------------------
Key: JAMES-684
URL: http://issues.apache.org/jira/browse/JAMES-684
Project: James
Issue Type: Bug
Reporter: Norman Maurer
Assigned To: Noel J. Bergman
After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Commented: (JAMES-684) testConnectionLimitExceeded junit test is broken
Posted by "Noel J. Bergman" <no...@devtech.com>.
Bernd Fondermann wrote:
> Noel J. Bergman wrote:
> > Perhaps we should just test that there IS a backlog, and not try to be
too precise.
> Probably. If this is OS or TCP specific, we should only test this if
> we would really like to unit test the OS or TCP. :-) We can take all
> things for granted out of scope of the unit we are testing.
Please review the current test, and let me know what you think. The test
presumes that there is a fixed number of connections that will be accepted,
a hard minimum of backlog connections, an upper bound of backlog connections
that can be measured, and well-defined behavior once that upper bound has
been reached.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-684) testConnectionLimitExceeded junit test is broken
Posted by Bernd Fondermann <be...@googlemail.com>.
On 11/10/06, Noel J. Bergman (JIRA) <se...@james.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/JAMES-684?page=comments#action_12448871 ]
>
> Noel J. Bergman commented on JAMES-684:
> ---------------------------------------
>
> I've added an improved test, but there is still a quirk regarding testing the extent of the backlog that raises questions about portability (of the test). See, for example, http://www.signaltonoise.net/library/ipsp00f.htm, which says (in part):
>
> Different TCP implementations have different backlog sizes. BSD generally
> has a backlog of 5 (Linux has a backlog of 6). There is also a 'grace' margin
> of 3/2. That is, TCP will allow up to backlog*3/2+1 connections. This will
> allow a socket one connection even if it calls listen with a backlog of 0.
>
> Perhaps we should just test that there IS a backlog, and not try to be too precise.
Probably. If this is OS or TCP specific, we should only test this if
we would really like to unit test the OS or TCP. :-)
We can take all things for granted out of scope of the unit we are testing.
Bernd
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-684) testConnectionLimitExceeded junit
test is broken
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=comments#action_12448757 ]
Noel J. Bergman commented on JAMES-684:
---------------------------------------
Resolved (for now) by commenting it out, with notes that the entire premise of the test is flawed.
What we want to see is that for some connection limit L and backlog size B, L clients can connect, and will be dispatched to workers, and B clients can connect and will be queueed. Any clients beyond B+L that attempt to connect should (precise timing may be somewhat stack dependent) be unable to establish a connection.
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Closed: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Noel J. Bergman closed JAMES-684.
---------------------------------
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Trunk
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
> Fix For: Trunk
>
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Closed: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Stefano Bagnara closed JAMES-684.
---------------------------------
Resolution: Fixed
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Next Major
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
> Fix For: Next Major
>
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Noel J. Bergman resolved JAMES-684.
-----------------------------------
Resolution: Fixed
Fix committed to trunk on 10 NOV 2006.
http://svn.apache.org/viewvc/james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java?r1=466117&r2=473583&diff_format=h
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Trunk
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-684) testConnectionLimitExceeded junit
test is broken
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=comments#action_12448871 ]
Noel J. Bergman commented on JAMES-684:
---------------------------------------
I've added an improved test, but there is still a quirk regarding testing the extent of the backlog that raises questions about portability (of the test). See, for example, http://www.signaltonoise.net/library/ipsp00f.htm, which says (in part):
Different TCP implementations have different backlog sizes. BSD generally
has a backlog of 5 (Linux has a backlog of 6). There is also a 'grace' margin
of 3/2. That is, TCP will allow up to backlog*3/2+1 connections. This will
allow a socket one connection even if it calls listen with a backlog of 0.
Perhaps we should just test that there IS a backlog, and not try to be too precise.
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Noel J. Bergman updated JAMES-684:
----------------------------------
Fix Version/s: Trunk
Affects Version/s: Trunk
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Trunk
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
> Fix For: Trunk
>
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Norman Maurer updated JAMES-684:
--------------------------------
Component/s: JUnit
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Reopened: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Stefano Bagnara reopened JAMES-684:
-----------------------------------
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Next Major
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
> Fix For: Next Major
>
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-684) testConnectionLimitExceeded junit test
is broken
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-684?page=all ]
Stefano Bagnara updated JAMES-684:
----------------------------------
Fix Version/s: Next Major
(was: Trunk)
Affects Version/s: Next Major
(was: Trunk)
Trunk should not be used as a fix version before we branch next-major.
current svn trunk is next-major and Trunk on jira is an alias for what we'll come after next-major.
> testConnectionLimitExceeded junit test is broken
> ------------------------------------------------
>
> Key: JAMES-684
> URL: http://issues.apache.org/jira/browse/JAMES-684
> Project: James
> Issue Type: Bug
> Components: JUnit
> Affects Versions: Next Major
> Reporter: Norman Maurer
> Assigned To: Noel J. Bergman
> Fix For: Next Major
>
>
> After JAMES-671 commits the test is broken. Plz fix
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org