You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/03 23:51:31 UTC

[GitHub] [pulsar] rivernate opened a new issue #8440: pulsar-admin cli namepsace offload policy labels deletion lag incorrectly

rivernate opened a new issue #8440:
URL: https://github.com/apache/pulsar/issues/8440


   **Describe the bug**
   When using the pulsar-admin cli tool to set an offload policy for a namespace, the deletion lag setting is labeled as "offloadAfterElapsedInMillis" and the documentation for the command describes it as setting the amount of elapsed time before an offload happens. What it actually sets is the deletion lag for the namespace
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Use the pulsar-admin cli to set a offload policy for a namespace
   2. in the policy specify the offloadAfterElapsedTime
   3. use the pulsar-admin cli to retrieve the policy
   4. The deletion lag setting was changed instead
   
   **Expected behavior**
   The documentation and options should be changed to correctly describe it as changing the deletion lag
   
   
   
   **Additional context**
   Add any other context about the problem here.
   
   See:
   https://github.com/apache/pulsar/blob/ec2de258ce39b38311e92bab6882c198070d8975/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java#L1598
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rivernate commented on issue #8440: pulsar-admin cli namepsace offload policy labels deletion lag incorrectly

Posted by GitBox <gi...@apache.org>.
rivernate commented on issue #8440:
URL: https://github.com/apache/pulsar/issues/8440#issuecomment-725648476


   We have been using 2.5.2, but it looks like it's still in the source code on the current master: https://github.com/apache/pulsar/blob/14c145e3d371c3ceab979277f4b2717d7046b4a5/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java#L1665
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on issue #8440: pulsar-admin cli namepsace offload policy labels deletion lag incorrectly

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #8440:
URL: https://github.com/apache/pulsar/issues/8440#issuecomment-722737014


   @rivernate Could you please provide the version information of the Pulsar broker and pulsar-client-admin?
   @gaoran10 Could you please help take a look at this issue, seems we have already fixed in the master branch, please help double-check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org