You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/10 06:25:54 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #31789: [SPARK-34677][SQL] Support the `+`/`-` operators over ANSI SQL intervals

cloud-fan commented on a change in pull request #31789:
URL: https://github.com/apache/spark/pull/31789#discussion_r591100803



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -173,6 +180,11 @@ abstract class BinaryArithmetic extends BinaryOperator with NullIntolerant {
   def calendarIntervalMethod: String =
     sys.error("BinaryArithmetics must override either calendarIntervalMethod or genCode")
 
+  /** Name of the function for this expression on [[DayTimeIntervalType]] and
+   *  [[YearMonthIntervalType]] types. */
+  def intervalMethod: String =

Review comment:
       Shall we reuse `exactMathMethod`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org