You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/09/19 23:07:39 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42999: [SPARK-45217][CORE] Support change log level of specific package or class

dongjoon-hyun commented on code in PR #42999:
URL: https://github.com/apache/spark/pull/42999#discussion_r1330789111


##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -1013,7 +1013,7 @@ private[spark] object Utils
    * In case of IPv6, getHostAddress may return '0:0:0:0:0:0:0:1'.
    */
   def localHostName(): String = {
-    addBracketsIfNeeded(customHostname.getOrElse(localIpAddress.getHostAddress))
+    addBracketsIfNeeded(customHostname.getOrElse(localIpAddress.getHostName))

Review Comment:
   This looks irrelevant to me. Why do you change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org