You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2018/05/03 20:53:04 UTC

[PROPOSAL] Eliminate most of the proxy.node metrics

In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:

1) Those which are purely copying from the corresponding proxy.process metric.

2) The _avg_ and _10s metrics

3) The ratios metrics.


I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.

I’ve prepared a PR with the changes:

	https://github.com/apache/trafficserver/pull/3567


The full list of removed metrics are listed in a comment there.

Cheers,

— leif


Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Bryan Call <bc...@apache.org>.
+1 - All of these are calculated and stat tracking tools can do it themselves

-Bryan

> On May 3, 2018, at 1:53 PM, Leif Hedstrom <zw...@apache.org> wrote:
> 
> In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:
> 
> 1) Those which are purely copying from the corresponding proxy.process metric.
> 
> 2) The _avg_ and _10s metrics
> 
> 3) The ratios metrics.
> 
> 
> I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
> 
> I’ve prepared a PR with the changes:
> 
> 	https://github.com/apache/trafficserver/pull/3567
> 
> 
> The full list of removed metrics are listed in a comment there.
> 
> Cheers,
> 
> — leif
> 


Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Bryan Call <bc...@apache.org>.
+1 - All of these are calculated and stat tracking tools can do it themselves

-Bryan

> On May 3, 2018, at 1:53 PM, Leif Hedstrom <zw...@apache.org> wrote:
> 
> In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:
> 
> 1) Those which are purely copying from the corresponding proxy.process metric.
> 
> 2) The _avg_ and _10s metrics
> 
> 3) The ratios metrics.
> 
> 
> I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
> 
> I’ve prepared a PR with the changes:
> 
> 	https://github.com/apache/trafficserver/pull/3567
> 
> 
> The full list of removed metrics are listed in a comment there.
> 
> Cheers,
> 
> — leif
> 


Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Leif Hedstrom <zw...@apache.org>.

> On May 4, 2018, at 12:13 PM, Steven R. Feltner <sf...@godaddy.com> wrote:
> 
> +1 - Agree that other external tools are better suited for collecting and calculating these metrics.
> 


Alright, calling this, and will land my PR once amc approves it.

— leif



Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Leif Hedstrom <zw...@apache.org>.

> On May 4, 2018, at 12:13 PM, Steven R. Feltner <sf...@godaddy.com> wrote:
> 
> +1 - Agree that other external tools are better suited for collecting and calculating these metrics.
> 


Alright, calling this, and will land my PR once amc approves it.

— leif



Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by "Steven R. Feltner" <sf...@godaddy.com>.
+1 - Agree that other external tools are better suited for collecting and calculating these metrics.

Thanks,
Steven

On 5/3/18, 4:53 PM, "Leif Hedstrom" <zw...@apache.org> wrote:

    In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:
    
    1) Those which are purely copying from the corresponding proxy.process metric.
    
    2) The _avg_ and _10s metrics
    
    3) The ratios metrics.
    
    
    I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
    
    I’ve prepared a PR with the changes:
    
    	https://github.com/apache/trafficserver/pull/3567
    
    
    The full list of removed metrics are listed in a comment there.
    
    Cheers,
    
    — leif
    
    


Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Patrick O'Brien <pa...@tetrisblocks.net>.
+1. Our production monitoring system ignores all of these metrics already.

On Thu, May 3, 2018 at 2:53 PM, Leif Hedstrom <zw...@apache.org> wrote:

> In an effort to clean things up, I’d like to remove a lot of the metrics
> that are calculated via metrics.config. There are three categories that I’m
> eliminating:
>
> 1) Those which are purely copying from the corresponding proxy.process
> metric.
>
> 2) The _avg_ and _10s metrics
>
> 3) The ratios metrics.
>
>
> I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty
> strongly belong in a monitoring software / tool, to better calculate
> changes and ratios.
>
> I’ve prepared a PR with the changes:
>
>         https://github.com/apache/trafficserver/pull/3567
>
>
> The full list of removed metrics are listed in a comment there.
>
> Cheers,
>
> — leif
>
>

Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by "Alan M. Carroll" <am...@network-geographics.com>.
+1. In our production these are all calculated in the data gathering system anyway, which gives a lot more flexibility (such as deciding on new computed metrics after the fact).

> In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:

> 1) Those which are purely copying from the corresponding proxy.process metric.

> 2) The _avg_ and _10s metrics

> 3) The ratios metrics.


> I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.

> I’ve prepared a PR with the changes:

>         https://github.com/apache/trafficserver/pull/3567


> The full list of removed metrics are listed in a comment there.

> Cheers,

> — leif




Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by Patrick O'Brien <pa...@tetrisblocks.net>.
+1. Our production monitoring system ignores all of these metrics already.

On Thu, May 3, 2018 at 2:53 PM, Leif Hedstrom <zw...@apache.org> wrote:

> In an effort to clean things up, I’d like to remove a lot of the metrics
> that are calculated via metrics.config. There are three categories that I’m
> eliminating:
>
> 1) Those which are purely copying from the corresponding proxy.process
> metric.
>
> 2) The _avg_ and _10s metrics
>
> 3) The ratios metrics.
>
>
> I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty
> strongly belong in a monitoring software / tool, to better calculate
> changes and ratios.
>
> I’ve prepared a PR with the changes:
>
>         https://github.com/apache/trafficserver/pull/3567
>
>
> The full list of removed metrics are listed in a comment there.
>
> Cheers,
>
> — leif
>
>

Re: [PROPOSAL] Eliminate most of the proxy.node metrics

Posted by "Steven R. Feltner" <sf...@godaddy.com>.
+1 - Agree that other external tools are better suited for collecting and calculating these metrics.

Thanks,
Steven

On 5/3/18, 4:53 PM, "Leif Hedstrom" <zw...@apache.org> wrote:

    In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:
    
    1) Those which are purely copying from the corresponding proxy.process metric.
    
    2) The _avg_ and _10s metrics
    
    3) The ratios metrics.
    
    
    I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
    
    I’ve prepared a PR with the changes:
    
    	https://github.com/apache/trafficserver/pull/3567
    
    
    The full list of removed metrics are listed in a comment there.
    
    Cheers,
    
    — leif