[GitHub] spark pull request #18308: [SPARK-21099][Spark Core] INFO Log Message Using ...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18308#discussion_r125189804
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -432,8 +432,10 @@ private[spark] class ExecutorAllocationManager(
         if (testing || executorsRemoved.nonEmpty) {
           executorsRemoved.foreach { removedExecutorId =>
             newExecutorTotal -= 1
    +        val hasCachedBlocks = SparkEnv.get.blockManager.master.hasCachedBlocks(removedExecutorId)
    +        val timeout = if (hasCachedBlocks) cachedExecutorIdleTimeoutS else executorIdleTimeoutS
             logInfo(s"Removing executor $removedExecutorId because it has been idle for " +
    -          s"$executorIdleTimeoutS seconds (new desired total will be $newExecutorTotal)")
    +          s"${if (SparkEnv.get.blockManager.master.hasCachedBlocks(executorId)) cachedExecutorIdleTimeoutS else executorIdleTimeoutS} seconds (new desired total will be $newExecutorTotal)")
    --- End diff --
    
    This is hard to read. @vanzin 's idea is better. Can you split this into two statements? cheap one at info, expensive one at debug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org