[jira] [Commented] (GERONIMO-6002) Can't configure defaultJspServlet parameters

["Kevan Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046952#comment-13046952 ] 

Kevan Miller commented on GERONIMO-6002:
----------------------------------------

With these changes, can now override xml attributes in config.xml. For instance:

{code}
    <module name="org.apache.geronimo.configs/jasper-deployer/3.0-SNAPSHOT/car">
      <gbean name="JspModuleBuilderExtension">
        <attribute name="defaultJspServlet">
          <web-app xmlns="http://java.sun.com/xml/ns/javaee">
            <servlet>
              <servlet-name>jsp</servlet-name>
              <servlet-class>org.apache.jasper.servlet.JspServlet</servlet-class>
              <init-param>
                <param-name>development</param-name>
                <param-value>true</param-value>
              </init-param>
              <init-param>
                <param-name>trimSpaces</param-name>
                <param-value>true</param-value>
              </init-param>
              <init-param>
                <param-name>fork</param-name>
                <param-value>false</param-value>
              </init-param>
              <init-param>
                <param-name>logVerbosityLevel</param-name>
                <param-value>DEBUG</param-value>
              </init-param>
              <init-param>
                <param-name>xpoweredBy</param-name>
                <param-value>false</param-value>
              </init-param>
              <init-param>
                <param-name>engineOptionsClass</param-name>
                <param-value>org.apache.geronimo.jasper.JspServletOptions</param-value>
              </init-param>
              <load-on-startup>0</load-on-startup>
            </servlet>
            <servlet-mapping>
              <servlet-name>jsp</servlet-name>
              <url-pattern>*.jsp</url-pattern>
              <url-pattern>*.jspf</url-pattern>
              <url-pattern>*.jspx</url-pattern>
              <url-pattern>*.xsp</url-pattern>
            </servlet-mapping>
          </web-app>
        </attribute>
      </gbean>
    </module>
{code}

Could add this to <config-xml-content> for jasper-deployer. But, should consider letting var/catalina/conf/web.xml control these settings. Something for later...

> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira