[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #37500: [SPARK-40049][SQL][TESTS] Add adaptive plan case in ReplaceNullWithFalseInPredicateEndToEndSuite

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #37500:
URL: https://github.com/apache/spark/pull/37500#discussion_r944927644


##########
sql/core/src/test/scala/org/apache/spark/sql/ReplaceNullWithFalseInPredicateEndToEndSuite.scala:
##########
@@ -19,16 +19,25 @@ package org.apache.spark.sql
 
 import org.apache.spark.sql.catalyst.expressions.{CaseWhen, If, Literal}
 import org.apache.spark.sql.execution.LocalTableScanExec
+import org.apache.spark.sql.execution.adaptive.{
+  AdaptiveSparkPlanHelper,
+  DisableAdaptiveExecutionSuite,
+  EnableAdaptiveExecutionSuite
+}

Review Comment:
   Hi, @kazuyukitanimura . This is not Apache Spark style. Please match with the code around your patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org