You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org> on 2005/07/20 21:49:45 UTC
[jira] Created: (TAPESTRY-422) ExternalService.getLink javadoc needs to inform that the returned URL is encoded
ExternalService.getLink javadoc needs to inform that the returned URL is encoded
--------------------------------------------------------------------------------
Key: TAPESTRY-422
URL: http://issues.apache.org/jira/browse/TAPESTRY-422
Project: Tapestry
Type: Improvement
Components: Documentation
Versions: 4.0, 3.0.3
Reporter: Andreas Andreou
Priority: Trivial
This may apply to other services as well.
The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Assigned: (TAPESTRY-422) ExternalService.getLink javadoc
needs to inform that the returned URL is encoded
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-422?page=all ]
Jesse Kuhnert reassigned TAPESTRY-422:
--------------------------------------
Assign To: Jesse Kuhnert
> ExternalService.getLink javadoc needs to inform that the returned URL is encoded
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-422
> URL: http://issues.apache.org/jira/browse/TAPESTRY-422
> Project: Tapestry
> Type: Improvement
> Components: Documentation
> Versions: 4.0, 3.0.3
> Reporter: Andreas Andreou
> Assignee: Jesse Kuhnert
> Priority: Trivial
> Attachments: TAPESTRY-422-branch-3.0.patch, TAPESTRY-422-trunk.patch
>
> This may apply to other services as well.
> The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
> It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
> However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Updated: (TAPESTRY-422) ExternalService.getLink javadoc
needs to inform that the returned URL is encoded
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-422?page=all ]
Brian K. Wallace updated TAPESTRY-422:
--------------------------------------
Attachment: TAPESTRY-422-branch-3.0.patch
TAPESTRY-422-trunk.patch
Patches to Javadoc to explicitly state that URLs returned from ExternalService will already be encoded.
> ExternalService.getLink javadoc needs to inform that the returned URL is encoded
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-422
> URL: http://issues.apache.org/jira/browse/TAPESTRY-422
> Project: Tapestry
> Type: Improvement
> Components: Documentation
> Versions: 3.0.3, 4.0
> Reporter: Andreas Andreou
> Priority: Trivial
> Attachments: TAPESTRY-422-branch-3.0.patch, TAPESTRY-422-trunk.patch
>
> This may apply to other services as well.
> The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
> It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
> However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Resolved: (TAPESTRY-422) ExternalService.getLink javadoc
needs to inform that the returned URL is encoded
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-422?page=all ]
Jesse Kuhnert resolved TAPESTRY-422:
------------------------------------
Fix Version: 4.0.1
3.0.4
Resolution: Fixed
patches applied
> ExternalService.getLink javadoc needs to inform that the returned URL is encoded
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-422
> URL: http://issues.apache.org/jira/browse/TAPESTRY-422
> Project: Tapestry
> Type: Improvement
> Components: Documentation
> Versions: 3.0.3, 4.0
> Reporter: Andreas Andreou
> Assignee: Jesse Kuhnert
> Priority: Trivial
> Fix For: 4.0.1, 3.0.4
> Attachments: TAPESTRY-422-branch-3.0.patch, TAPESTRY-422-trunk.patch
>
> This may apply to other services as well.
> The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
> It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
> However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Closed: (TAPESTRY-422) ExternalService.getLink javadoc needs
to inform that the returned URL is encoded
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-422?page=all ]
Brian K. Wallace closed TAPESTRY-422:
-------------------------------------
> ExternalService.getLink javadoc needs to inform that the returned URL is encoded
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-422
> URL: http://issues.apache.org/jira/browse/TAPESTRY-422
> Project: Tapestry
> Type: Improvement
> Components: Documentation
> Versions: 3.0.3, 4.0
> Reporter: Andreas Andreou
> Assignee: Jesse Kuhnert
> Priority: Trivial
> Fix For: 4.0.1, 3.0.4
> Attachments: TAPESTRY-422-branch-3.0.patch, TAPESTRY-422-trunk.patch
>
> This may apply to other services as well.
> The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
> It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
> However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org