You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/07/21 05:04:15 UTC

[GitHub] [hadoop] aajisaka commented on pull request #2155: HADOOP-17138. Fix spotbugs warnings surfaced after upgrade to 4.0.6.

aajisaka commented on pull request #2155:
URL: https://github.com/apache/hadoop/pull/2155#issuecomment-661635176


   Thank you @iwasakims for the PR.
   
   How about fixing `DLS_DEAD_LOCAL_STORE` instead of ignoring the warning?
   For example, in FSEditLogLoader#incrOpCount
   ```diff
   -      holder.held++;
   +      holder.held = holder.held + 1;
   ```
   fixes the warning and removes unnecessary operations.
   
   I ran `javap -c -p` to the class and found the unnecessary operations even in OpenJDK 11.0.7.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org