You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/03/01 02:34:12 UTC
Review Request 65853: Updated createQuotaInfo helper to handle quota
limit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65853/
-----------------------------------------------------------
Review request for mesos, Michael Park and Meng Zhu.
Repository: mesos
Description
-------
Note that this has no effect on the existing code paths since the
limit will be empty.
Diffs
-----
src/master/quota.hpp 7f43996d9aa3d3f462a6ed750733a55d4ef770c8
src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
Diff: https://reviews.apache.org/r/65853/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 65853: Updated createQuotaInfo helper to handle
quota limit.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65853/#review198432
-----------------------------------------------------------
PASS: Mesos patch 65853 was successfully built and tested.
Reviews applied: `['65334', '65851', '65852', '65780', '65781', '65782', '65783', '65784', '65785', '65853']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65853
- Mesos Reviewbot Windows
On March 1, 2018, 2:34 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65853/
> -----------------------------------------------------------
>
> (Updated March 1, 2018, 2:34 a.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note that this has no effect on the existing code paths since the
> limit will be empty.
>
>
> Diffs
> -----
>
> src/master/quota.hpp 7f43996d9aa3d3f462a6ed750733a55d4ef770c8
> src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
>
>
> Diff: https://reviews.apache.org/r/65853/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65853: Updated createQuotaInfo helper to handle
quota limit.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65853/#review198437
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65334, 65851, 65852, 65780, 65781, 65782, 65783, 65784, 65785, 65853]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2018, 6:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65853/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:34 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note that this has no effect on the existing code paths since the
> limit will be empty.
>
>
> Diffs
> -----
>
> src/master/quota.hpp 7f43996d9aa3d3f462a6ed750733a55d4ef770c8
> src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
>
>
> Diff: https://reviews.apache.org/r/65853/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65853: Updated createQuotaInfo helper to handle
quota limit.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65853/#review199395
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Feb. 28, 2018, 6:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65853/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 6:34 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note that this has no effect on the existing code paths since the
> limit will be empty.
>
>
> Diffs
> -----
>
> src/master/quota.hpp 7f43996d9aa3d3f462a6ed750733a55d4ef770c8
> src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
>
>
> Diff: https://reviews.apache.org/r/65853/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>