You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/03 18:33:45 UTC
[GitHub] williaster commented on a change in pull request #3767: [time table] add tooltip to sparkline
williaster commented on a change in pull request #3767: [time table] add tooltip to sparkline
URL: https://github.com/apache/incubator-superset/pull/3767#discussion_r148862826
##########
File path: superset/assets/visualizations/time_table.jsx
##########
@@ -53,13 +54,12 @@ function viz(slice, payload) {
}
const tableData = metrics.map((metric) => {
let leftCell;
- const context = Object.assign({}, fd, { metric });
- const url = fd.url ? Mustache.render(fd.url, context) : null;
Review comment:
ohhh, yeah I didn't understand what this was doing fully/thought it was forcing the url to be within the app. added it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services