You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/14 10:33:32 UTC

[GitHub] zentol opened a new pull request #7095: [FLINK-10867][metrics] Cache logical scopes separately for each reporter

zentol opened a new pull request #7095: [FLINK-10867][metrics] Cache logical scopes separately for each reporter
URL: https://github.com/apache/flink/pull/7095
 
 
   ## What is the purpose of the change
   
   This PR fixes an issue in the metric system where the logical scope was not cached separately for each reporter. As a result other reporters might access logical scopes for which the wrong filter and/or delimiter was used.
   
   ## Brief change log
   
   * cache logicalScopeStrings separately each reporter
   * modify `FrontMetricGroup` to inject reporterIndex when computing logical scope
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   * run `AbstractMetricGroupTest#testLogicalScopeCachingForMultipleReporters`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services