You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Tomas Havelka (JIRA)" <de...@myfaces.apache.org> on 2008/01/10 11:12:34 UTC

[jira] Created: (TRINIDAD-892) PanelTabbed immediate does not work

PanelTabbed immediate does not work
-----------------------------------

                 Key: TRINIDAD-892
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.0.4-core
            Reporter: Tomas Havelka
             Fix For: 1.0.5-core


Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-892) PanelTabbed immediate does not work

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557793#action_12557793 ] 

Scott O'Bryan commented on TRINIDAD-892:
----------------------------------------

I think this is as designed.  I'm not sure the "immediate" attribute is to be used to skip validation.

> PanelTabbed immediate does not work
> -----------------------------------
>
>                 Key: TRINIDAD-892
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Tomas Havelka
>             Fix For: 1.0.5-core
>
>
> Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-892) PanelTabbed immediate does not work

Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558022#action_12558022 ] 

Scott O'Bryan commented on TRINIDAD-892:
----------------------------------------

Well that would be why I didn't close the bug..  :)  Yeah I'm not sure what the correct behavior is here.  I just seem to remember something from WAY back (pre-apache) where items in close tabs were NOT getting validated on a page submission so we were thinking about forcing the tabs to no navigate under this condition.  Still, immediate must be expressly invoked, so I suppose validating by default is enough and allowing the immediate flag to skip validation would give us some extra flexibility.

I would be interested in hearing from someone who has worked on this code recently, however, to get their take on what impact this might have.

> PanelTabbed immediate does not work
> -----------------------------------
>
>                 Key: TRINIDAD-892
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Tomas Havelka
>             Fix For: 1.0.5-core
>
>
> Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-892) PanelTabbed immediate does not work

Posted by "Tomas Havelka (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557933#action_12557933 ] 

Tomas Havelka commented on TRINIDAD-892:
----------------------------------------

I think it should as same as the other command components. In addition it's preseneted in trinidad demo (see http://www.irian.at/trinidad-demo/faces/components/showDetailItem.jspx)

> PanelTabbed immediate does not work
> -----------------------------------
>
>                 Key: TRINIDAD-892
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Tomas Havelka
>             Fix For: 1.0.5-core
>
>
> Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-892) PanelTabbed immediate does not work

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557934#action_12557934 ] 

Martin Marinschek commented on TRINIDAD-892:
--------------------------------------------

I'd say Tomas is right - immediate's only use is to pass on conversion, validation, update model and execute invoke application directly after decode.

regards,

Martin

> PanelTabbed immediate does not work
> -----------------------------------
>
>                 Key: TRINIDAD-892
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Tomas Havelka
>             Fix For: 1.0.5-core
>
>
> Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-892) PanelTabbed immediate does not work

Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558019#action_12558019 ] 

Andrew Robinson commented on TRINIDAD-892:
------------------------------------------

What will be interesting is checking to ensure that other tabs (not the selected one) are updated/validated. If they aren't allowing immediate will have some nasty side effects. I have not researched this enough to know if it does or not.

> PanelTabbed immediate does not work
> -----------------------------------
>
>                 Key: TRINIDAD-892
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-892
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.4-core
>            Reporter: Tomas Havelka
>             Fix For: 1.0.5-core
>
>
> Immediate attribute in ShowDetailItem component embedded in PanelTabbed does not work at all. It always calls validation and tab page cannot be changed when the active one contains not valid data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.