[GitHub] [incubator-pegasus] Smityz commented on a diff in pull request #1371: refactor(conf): use DSN_DEFINE_string to load string type of configs

["Smityz (via GitHub)" <gi...@apache.org>]

Smityz commented on code in PR #1371:
URL: https://github.com/apache/incubator-pegasus/pull/1371#discussion_r1119640682


##########
src/zookeeper/zookeeper_session_mgr.cpp:
##########
@@ -38,16 +38,16 @@
 #include <stdio.h>
 #include <zookeeper/zookeeper.h>
 #include <stdexcept>
+#include "utils/flags.h"
 
 namespace dsn {
 namespace dist {
 
+DSN_DEFINE_string(zookeeper, logfile, "", "The Zookeeper logfile");
+
 zookeeper_session_mgr::zookeeper_session_mgr()
 {
-    _zoo_hosts = dsn_config_get_value_string("zookeeper", "hosts_list", "", "zookeeper_hosts");
-    _zoo_logfile = dsn_config_get_value_string("zookeeper", "logfile", "", "zookeeper logfile");
-
-    FILE *fp = fopen(_zoo_logfile.c_str(), "a");
+    FILE *fp = fopen(FLAGS_logfile, "a");

Review Comment:
   what's the meaning of "a"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org