You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by ih...@apache.org on 2011/06/04 11:39:39 UTC

svn commit: r1131361 - /logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php

Author: ihabunek
Date: Sat Jun  4 09:39:38 2011
New Revision: 1131361

URL: http://svn.apache.org/viewvc?rev=1131361&view=rev
Log:
Removed output buffering from LoggerAppenderConsoleTest since it doesn't work anyway (see FIXME note in file).

Modified:
    logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php

Modified: logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php
URL: http://svn.apache.org/viewvc/logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php?rev=1131361&r1=1131360&r2=1131361&view=diff
==============================================================================
--- logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php (original)
+++ logging/log4php/trunk/src/test/php/appenders/LoggerAppenderConsoleTest.php Sat Jun  4 09:39:38 2011
@@ -30,6 +30,15 @@
  */
 class LoggerAppenderConsoleTest extends PHPUnit_Framework_TestCase {
     
+	private $event;
+	
+	public function setUp()
+	{
+		$logger = new Logger('mycategory');
+		$level = LoggerLevel::getLevelWarn();
+		$this->event = new LoggerLoggingEvent(__CLASS__, $logger, $level, "my message");
+	}
+	
 	public function testRequiresLayout() {
 		$appender = new LoggerAppenderConsole(); 
 		self::assertTrue($appender->requiresLayout());
@@ -38,54 +47,32 @@ class LoggerAppenderConsoleTest extends 
     public function testSimpleStdOutLogging() {
     	$layout = new LoggerLayoutSimple();
     	
-    	$event = new LoggerLoggingEvent('LoggerAppenderConsoleTest', 
-    									new Logger('mycategory'), 
-    									LoggerLevel::getLevelWarn(),
-    									"my message");
-    	
     	$appender = new LoggerAppenderConsole("mylogger"); 
     	$appender->setTarget('STDOUT');
 		$appender->setLayout($layout);
 		$appender->activateOptions();
-
-		ob_start();
-		$appender->append($event);
-		$v = ob_get_contents();
-		ob_end_clean();
-
+		$appender->append($this->event);
 		$appender->close();
-		
     }
 
     public function testSimpleStdErrLogging() {
     	$layout = new LoggerLayoutSimple();
     	
-    	$event = new LoggerLoggingEvent('LoggerAppenderConsoleTest', 
-    									new Logger('mycategory'), 
-    									LoggerLevel::getLevelWarn(),
-    									"my message");
-    	
     	$appender = new LoggerAppenderConsole("mylogger"); 
 		$appender->setTarget('STDERR');
 		$appender->setLayout($layout);
 		$appender->activateOptions();
-		$appender->append($event);
+		$appender->append($this->event);
 		$appender->close();
     }    
 
-
     public function testSimpleDefaultLogging() {
     	$layout = new LoggerLayoutSimple();
     	
-    	$event = new LoggerLoggingEvent('LoggerAppenderConsoleTest', 
-    									new Logger('mycategory'), 
-    									LoggerLevel::getLevelWarn(),
-    									"my message");
-    	
     	$appender = new LoggerAppenderConsole("mylogger"); 
 		$appender->setLayout($layout);
 		$appender->activateOptions();
-		$appender->append($event);
+		$appender->append($this->event);
 		$appender->close();
     }
 }