You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/02/26 19:14:29 UTC
cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/gui/action EnableComponent.java
sebb 2004/02/26 10:14:29
Modified: src/core/org/apache/jmeter/gui/action EnableComponent.java
Log:
See [Bug 27265] - disable does not work
This fix seems to work, but may be more than needed...
Revision Changes Path
1.7 +4 -2 jakarta-jmeter/src/core/org/apache/jmeter/gui/action/EnableComponent.java
Index: EnableComponent.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/action/EnableComponent.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- EnableComponent.java 20 Feb 2004 02:35:44 -0000 1.6
+++ EnableComponent.java 26 Feb 2004 18:14:29 -0000 1.7
@@ -52,11 +52,13 @@
{
log.debug("enabling current gui object");
GuiPackage.getInstance().getCurrentNode().setEnabled(true);
+ GuiPackage.getInstance().getCurrentGui().setEnabled(true);
}
else if (e.getActionCommand().equals(DISABLE))
{
log.debug("disabling current gui object");
GuiPackage.getInstance().getCurrentNode().setEnabled(false);
+ GuiPackage.getInstance().getCurrentGui().setEnabled(false);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/gui/action
EnableComponent.java
Posted by Jordi Salvat i Alabart <js...@atg.com>.
Hi Sebb.
I believe your's is the best possible fix right now.
IMO, the correct fix would be to have the set/isEnabled methods in the
GUI just call the corresponding ones in the node.
But this would involve putting the JMeterGuiComponent.setNode method
back in use, which looks like an Herculean job right now. I won't do it
-- or not now. (Note this would fix another issue: the component name
would be ported to the tree as you type it in the GUI, or so it seems
from the NamePanel code).
I have a strong impression that all this code has too much history in
its back and needs serious clean-up -- including reviewing the APIs and
contracts. I'm thinking about the TestBean concept being able to replace
all this mess...
--
Salut,
Jordi.
Jordi Salvat i Alabart wrote:
> I touched this code section a few days ago, so it's probably my fault.
> I'll have a look...
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/gui/action
EnableComponent.java
Posted by Jordi Salvat i Alabart <js...@atg.com>.
I touched this code section a few days ago, so it's probably my fault.
I'll have a look...
--
Salut,
Jordi.
sebb@apache.org wrote:
> sebb 2004/02/26 10:14:29
>
> Modified: src/core/org/apache/jmeter/gui/action EnableComponent.java
> Log:
> See [Bug 27265] - disable does not work
> This fix seems to work, but may be more than needed...
>
> Revision Changes Path
> 1.7 +4 -2 jakarta-jmeter/src/core/org/apache/jmeter/gui/action/EnableComponent.java
>
> Index: EnableComponent.java
> ===================================================================
> RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/action/EnableComponent.java,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -r1.6 -r1.7
> --- EnableComponent.java 20 Feb 2004 02:35:44 -0000 1.6
> +++ EnableComponent.java 26 Feb 2004 18:14:29 -0000 1.7
> @@ -52,11 +52,13 @@
> {
> log.debug("enabling current gui object");
> GuiPackage.getInstance().getCurrentNode().setEnabled(true);
> + GuiPackage.getInstance().getCurrentGui().setEnabled(true);
> }
> else if (e.getActionCommand().equals(DISABLE))
> {
> log.debug("disabling current gui object");
> GuiPackage.getInstance().getCurrentNode().setEnabled(false);
> + GuiPackage.getInstance().getCurrentGui().setEnabled(false);
> }
> }
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org