You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/05/17 21:28:08 UTC
[jira] [Created] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Gregory Chanan created HBASE-6039:
-------------------------------------
Summary: Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
Key: HBASE-6039
URL: https://issues.apache.org/jira/browse/HBASE-6039
Project: HBase
Issue Type: Task
Components: ipc, master
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Fix For: 0.96.0
Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398971#comment-13398971 ]
Gregory Chanan commented on HBASE-6039:
---------------------------------------
Here's my idea for a breakdown into two protocols: Administrative and Monitoring. Below lists the functions for each. Any comments welcome.
Administrative Master Actions (MasterAdminProtocol):
addColumn
modifyColumn
deleteColumn
offlineRegion
assignRegion
unassignRegion
moveRegion
createTable
deleteTable
disableTable
modifyTable
enableTable
shutdown
stopMaster
balance
setBalancerRunning
Monitoring Master Actions (MasterMonitorProtocol):
isMasterRunning
getSchemaAlterStatus
getClusterStatus
getTableDescriptors
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6039:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the fat patch Gregory.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039-v2.patch, HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403649#comment-13403649 ]
Gregory Chanan commented on HBASE-6039:
---------------------------------------
Not sure if the review board stuff shows up anymore; I put a review up at:
https://reviews.apache.org/r/5652/
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405329#comment-13405329 ]
stack commented on HBASE-6039:
------------------------------
I added comments up on RB Gregory. Good work.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278151#comment-13278151 ]
Gregory Chanan commented on HBASE-6039:
---------------------------------------
@Andrew:
sounds good to me.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6039:
----------------------------------
Attachment: HBASE-6039.patch
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6039:
----------------------------------
Status: Patch Available (was: Open)
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403654#comment-13403654 ]
Hadoop QA commented on HBASE-6039:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12533922/HBASE-6039.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2289//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2289//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2289//console
This message is automatically generated.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6039:
----------------------------------
Attachment: HBASE-6039-v2.patch
* Attached HBASE-6039-v2.patch *
Matches reviewboard.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039-v2.patch, HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406179#comment-13406179 ]
Hudson commented on HBASE-6039:
-------------------------------
Integrated in HBase-TRUNK #3094 (See [https://builds.apache.org/job/HBase-TRUNK/3094/])
HBASE-6039 Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol (Revision 1356920)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/MasterAdminProtocol.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/MasterMonitorProtocol.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/MasterProtocol.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MasterAdminKeepAliveConnection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/MasterMonitorKeepAliveConnection.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterMonitorProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-server/src/main/protobuf/MasterAdmin.proto
* /hbase/trunk/hbase-server/src/main/protobuf/MasterMonitor.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039-v2.patch, HBASE-6039.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace
with something similar to RegionServerStatusProtocol
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278143#comment-13278143 ]
Andrew Purtell commented on HBASE-6039:
---------------------------------------
While you're in this area, currently if you have set up security and have enabled Hadoop service authorization, there is only one ACL that grants permission to HMasterInterface, however clients will want to access a subset of it for listing tables. We should separate truly administrative methods to another interface and separately protect it.
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: ipc, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira