You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/06/14 15:00:10 UTC

[GitHub] [iceberg] Fokko commented on a diff in pull request #7823: Python: Fixes for D205 issues

Fokko commented on code in PR #7823:
URL: https://github.com/apache/iceberg/pull/7823#discussion_r1229768086


##########
python/pyiceberg/utils/deprecated.py:
##########
@@ -20,9 +20,9 @@
 
 
 def deprecated(deprecated_in: str, removed_in: str, help_message: Optional[str] = None) -> Callable:  # type: ignore
-    """
-    This is a decorator which can be used to mark functions as deprecated.
-    It will result in a warning being emitted when the function is used.
+    """A decorator which can be used to mark functions as depricated.

Review Comment:
   ```suggestion
       """A decorator which can be used to mark functions as deprecated.
   ```



##########
python/pyiceberg/utils/deprecated.py:
##########
@@ -20,9 +20,9 @@
 
 
 def deprecated(deprecated_in: str, removed_in: str, help_message: Optional[str] = None) -> Callable:  # type: ignore
-    """
-    This is a decorator which can be used to mark functions as deprecated.
-    It will result in a warning being emitted when the function is used.
+    """A decorator which can be used to mark functions as depricated.
+
+    adding this will result in a warning being emitted when the function is used.

Review Comment:
   ```suggestion
       Adding this will result in a warning being emitted when the function is used.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org