You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/06 04:26:00 UTC
[jira] [Work logged] (GOBBLIN-1345) Implement a Kafka schema change
detecting converter
[ https://issues.apache.org/jira/browse/GOBBLIN-1345?focusedWorklogId=531675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531675 ]
ASF GitHub Bot logged work on GOBBLIN-1345:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/21 04:25
Start Date: 06/Jan/21 04:25
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3182:
URL: https://github.com/apache/incubator-gobblin/pull/3182#issuecomment-755069568
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=h1) Report
> Merging [#3182](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=desc) (5d92a7d) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/b1006b4da3f036cffdb81978faf3f26f3e577f76?el=desc) (b1006b4) will **decrease** coverage by `37.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3182 +/- ##
============================================
- Coverage 46.18% 9.11% -37.07%
+ Complexity 9753 1726 -8027
============================================
Files 2014 2016 +2
Lines 77095 77155 +60
Branches 8559 8567 +8
============================================
- Hits 35606 7036 -28570
- Misses 38182 69432 +31250
+ Partials 3307 687 -2620
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/GenericRecordBasedKafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9HZW5lcmljUmVjb3JkQmFzZWRLYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...e/gobblin/converter/KafkaSchemaChangeInjector.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9LYWZrYVNjaGVtYUNoYW5nZUluamVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1062 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=footer). Last update [b1006b4...5d92a7d](https://codecov.io/gh/apache/incubator-gobblin/pull/3182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 531675)
Time Spent: 0.5h (was: 20m)
> Implement a Kafka schema change detecting converter
> ---------------------------------------------------
>
> Key: GOBBLIN-1345
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1345
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For long-running Gobblin pipelines such as Gobblin-Kafka with streaming mode enabled, we need the ability for the pipeline to detect upstream schema changes to enable proper handling by downstream constructs. For instance, in the case of sinks such as HDFS and blob stores, such schema changes should result in the writer closing any open files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)