You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/14 23:12:34 UTC
[GitHub] codecov-io edited a comment on issue #3683: Optimize imports for
all files
codecov-io edited a comment on issue #3683: Optimize imports for all files
URL: https://github.com/apache/incubator-pinot/pull/3683#issuecomment-453676913
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=h1) Report
> Merging [#3683](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c42af32b2fae92c741a68c59ae90a1c19061887e?src=pr&el=desc) will **increase** coverage by `9.78%`.
> The diff coverage is `91.83%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3683/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3683 +/- ##
===========================================
+ Coverage 57.32% 67.1% +9.78%
Complexity 4 4
===========================================
Files 1027 1027
Lines 50863 50863
Branches 7106 7106
===========================================
+ Hits 29155 34134 +4979
+ Misses 19557 14406 -5151
- Partials 2151 2323 +172
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `79.33% <ø> (+4.13%)` | `0 <0> (ø)` | :arrow_down: |
| [...elix/core/minion/generator/TaskGeneratorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9nZW5lcmF0b3IvVGFza0dlbmVyYXRvclV0aWxzLmphdmE=) | `84.61% <ø> (+84.61%)` | `0 <0> (ø)` | :arrow_down: |
| [.../pinot/common/utils/ClientSSLContextGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ2xpZW50U1NMQ29udGV4dEdlbmVyYXRvci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/pinot/common/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvSnNvblV0aWxzLmphdmE=) | `43.47% <ø> (+2.17%)` | `0 <0> (ø)` | :arrow_down: |
| [...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0Jyb2tlclJlc3BvbnNlTmF0aXZlLmphdmE=) | `90.47% <ø> (+4.76%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/pql/parsers/pql2/ast/StarColumnListAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TdGFyQ29sdW1uTGlzdEFzdE5vZGUuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `80.39% <ø> (+11.37%)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `93.9% <ø> (+34.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...realtime/segment/DefaultFlushThresholdUpdater.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvRGVmYXVsdEZsdXNoVGhyZXNob2xkVXBkYXRlci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9TZWdtZW50U3RhdHVzQ2hlY2tlci5qYXZh) | `89.06% <ø> (+2.34%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [590 more](https://codecov.io/gh/apache/incubator-pinot/pull/3683/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=footer). Last update [c42af32...feaa1bd](https://codecov.io/gh/apache/incubator-pinot/pull/3683?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org