You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tapestry.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/12/16 02:46:15 UTC

[jira] [Commented] (TAP5-1979) Changing the implementation of a method after adding method advice does not work; the original implementation remains

    [ https://issues.apache.org/jira/browse/TAP5-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533240#comment-13533240 ] 

Hudson commented on TAP5-1979:
------------------------------

Integrated in tapestry-trunk-freestyle #977 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/977/])
    TAP5-1979: Changing the implementation of a method after adding method advice does not work; the original implementation remains (Revision ac0f494bfebdce230b914ab993ec056f083e2797)
Track status of TAP5-1979 (Revision b0e1e9b1bc3a3599e72b5dfd2c5c5f02b074ed5f)

     Result = FAILURE
hlship : 
Files : 
* plastic/src/test/java/testsubjects/AdviceAndImplementationSubject.java
* plastic/src/main/java/org/apache/tapestry5/internal/plastic/MethodAdviceManager.java
* plastic/src/test/groovy/org/apache/tapestry5/plastic/MethodAdviceTests.groovy

hlship : 
Files : 
* 54_RELEASE_NOTES.txt

                
> Changing the implementation of a method after adding method advice does not work; the original implementation remains
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1979
>                 URL: https://issues.apache.org/jira/browse/TAP5-1979
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: plastic
>    Affects Versions: 5.3, 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>              Labels: fixed-in-5.4-js-rewrite
>             Fix For: 5.3.5, 5.4
>
>
> This is too easy to do when you have a chain of PlasticClassTransformers operating on the same classes.
> Alternately, the advised method, not the main method (that instantiates the Invocation object)n should be the one that is rewritten.
> The issue here is that Plastic takes a snapshot of the method implementation when the first advice is added, and that snapshot is not updated if the advised method implementation is later changed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira