[GitHub] [storm] Ethanlm commented on a change in pull request #2990: STORM-3372: Fix NPE when shutting down HdfsBolt, fix storm-hdfs tests not running

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #2990: STORM-3372: Fix NPE when shutting down HdfsBolt, fix storm-hdfs tests not running
URL: https://github.com/apache/storm/pull/2990#discussion_r308310631
 
 

 ##########
 File path: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestHdfsBolt.java
 ##########
 @@ -203,6 +204,17 @@ public void testTickTuples() throws IOException {
         //Tick should have flushed it
         Assert.assertEquals(1, countNonZeroLengthFiles(testRoot));
     }
+    
+    @Test
+    public void testShutdownStorm3372() {
+        //STORM-3372: Rotation policy other than TimedRotationPolicy causes NPE on cleanup
 
 Review comment:
   I prefer to not use jira number as a test case name. Just name the test case as what it is about will be better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services