You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/31 02:33:05 UTC

[GitHub] [iotdb] THUMarkLau opened a new pull request #5384: [IOTDB-2818] Fix exception occurs when submitting compaction task to global queue

THUMarkLau opened a new pull request #5384:
URL: https://github.com/apache/iotdb/pull/5384


   The detail see [IOTDB-2818](https://issues.apache.org/jira/browse/IOTDB-2818)
   
   The reason for this bug is as follow. When submitting a compaction task to global queue, system doesn't check the status of TsFileResource and just set it to `COMPACTION_CANDIDATE`. It will not check if the tsfile is closed until the task is submitted to be executed. In [PR-5198](https://github.com/apache/iotdb/pull/5198), we combine multiple status flags for TsFileResource into one enum variable, and check the status transition of the TsFileResource. If a TsFileResource status is `UNCLOSED`, it cannot be set to `COMPACTION_CANDIDATE`. So we need to check if the TsFileResource is `UNCLOSED` before we set it to `COMPACTION_CANDIDATE`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] qiaojialin merged pull request #5384: [IOTDB-2818] Fix exception occurs when submitting compaction task to global queue

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5384:
URL: https://github.com/apache/iotdb/pull/5384


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org