[jira] [Commented] (OAK-5070) Journal diff not working for changes in bundled node

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643848#comment-15643848 ] 

Chetan Mehrotra commented on OAK-5070:
--------------------------------------

Discussed with Marcel

For now disabled the bundling feature by default with r1768496. Once we decide the fix for this issue it would need to be enabled back

bq. What to do if commitRoot itself is bundled. What should be the depth. Should it be depth of bundling root?

Commit root should always be a NodeDocument ID. So in case whole commit is part of bundled nodes only then it would be id of the bundling root

bq. How would the diff work when it is not back by journal diff. diffFewChildren and diffManyChildren would need some change

diffFewChildren (used for upto 50 child nodes) should work fine as it depends on NodeState. However diffManyChildren would pose problem. Opened OAK-5079 for that

> Journal diff not working for changes in bundled node
> ----------------------------------------------------
>
>                 Key: OAK-5070
>                 URL: https://issues.apache.org/jira/browse/OAK-5070
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>              Labels: bundling
>             Fix For: 1.6
>
>         Attachments: OAK-5070-v1.patch
>
>
> For changes in bundled nodes diff is not reporting change in properties of bundled node



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)