You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2019/02/20 22:55:00 UTC

[GitHub] afs commented on issue #535: JENA-1674: Don't sign extend Float.floatToIntBits.

afs commented on issue #535: JENA-1674: Don't sign extend Float.floatToIntBits.
URL: https://github.com/apache/jena/pull/535#issuecomment-465788847
 
 
   Sorry @rvesse - discovered I'd been running the wrong test suite and the original PR was not passing. Caught thanks to TravisCI. The only change is in `TestNodeIdInline.nodeId_float_6` which was 
   
   Wrong (the reconstructed value isn't lexical `"1"`:
   ```
       @Test public void nodeId_float_6()
       { test("'-1'^^xsd:float") ; }
   ```
   fixed:
   ```
       @Test public void nodeId_float_6()
       { test("'-1'^^xsd:float", "'-1.0'^^xsd:float") ; }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services