[jira] [Commented] (FLINK-3150) Make YARN container invocation configurable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794827#comment-15794827 ] 

ASF GitHub Bot commented on FLINK-3150:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3056

    [FLINK-3150] make YARN container invocation configurable

    By using the `yarn.container-start-command-template` configuration parameter, the Flink start command can be altered/extended. By default, it is set to `"%java% %jvmmem% %jvmopts% %logging% %class% %args% %redirects%"` with
    - `java` = path to the Java executable
    - `jvmmem` = JVM memory limits and tweaks
    - `jvmopts` = misc options for the Java VM
    - `logging` = logging-related configuration settings
    - `class` = main class to execute
    - `args` = arguments for the main class
    - `redirects` = output redirects
    
    @rmetzger this is based on your previous pull request (https://github.com/apache/flink/pull/1446/files), can you have a look?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink FLINK-3150

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3056
    
----
commit f36599778d5e28401d68bbdd39d0c55e2eee3d0b
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-02T15:17:09Z

    [hotfix] fix YARN TM krb5 conf only available when logging enabled

commit f112d0c46d205623712fd8cda0c798152150dfb1
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-02T16:44:38Z

    [FLINK-3150] add a test for BootstrapTools#getTaskManagerShellCommand

commit deb04f971764a675b5e39a5609465f0179fa8d02
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-03T10:53:23Z

    [FLINK-3150] add a test for AbstractYarnClusterDescriptor#setupApplicationMasterContainer

commit a140f34ebe728c77f8afc051b3dda0066a252bc6
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-02T16:01:21Z

    [FLINK-3150] make YARN container invocation configurable
    
    By using the `yarn.container-start-command-template` configuration parameter,
    the Flink start command can be altered/extended. By default, it is set to
    `"%java% %jvmmem% %jvmopts% %logging% %class% %args% %redirects%"` with
    - `java` = path to the Java executable
    - `jvmmem` = JVM memory limits and tweaks
    - `jvmopts` = misc options for the Java VM
    - `logging` = logging-related configuration settings
    - `class` = main class to execute
    - `args` = arguments for the main class
    - `redirects` = output redirects
    
    This is based on a previous pull request and commits by @rmetzger, i.e.
    https://github.com/apache/flink/pull/1446/files

commit b17d563a626da17c82476a4b76fd62da325e4396
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-02T17:26:31Z

    [FLINK-3150] fe-factor BootstrapToolsTest#testGetTaskManagerShellCommand
    
    -> reduce duplication of strings for easier test changes

commit 6ff6724c2935956a0deea51286eb0930652a165f
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-01-02T17:27:33Z

    [FLINK-3150] extend BootstrapToolsTest#testGetTaskManagerShellCommand
    
    This now also tests some variants changing the new
    `yarn.container-start-command-template` configuration parameter.

----


> Make YARN container invocation configurable
> -------------------------------------------
>
>                 Key: FLINK-3150
>                 URL: https://issues.apache.org/jira/browse/FLINK-3150
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: Robert Metzger
>            Assignee: Nico Kruber
>              Labels: qa
>
> Currently, the JVM invocation call of YARN containers is hardcoded.
> With this change, I would like to make the call configurable, using a string such as
> "%java% %memopts% %jvmopts% ..."
> Also, we should respect the {{java.env.home}} if its set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)