You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "freddieptf (via GitHub)" <gi...@apache.org> on 2024/03/22 18:03:41 UTC
[PR] fix: correctly encode ticket [arrow-rs]
freddieptf opened a new pull request, #5543:
URL: https://github.com/apache/arrow-rs/pull/5543
# Which issue does this PR close?
Closes #5540
# Rationale for this change
Fixes the Flight SQL example so we can browse through catalogs, schema and tables when using the JDBC driver
# What changes are included in this PR?
Adds call to `as_any()` to convert to the correct type before encoding to bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correctly encode ticket [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5543:
URL: https://github.com/apache/arrow-rs/pull/5543#issuecomment-2016946718
Perhaps @avantgardnerio or @alamb might be able to give this a sanity check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correctly encode ticket [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5543:
URL: https://github.com/apache/arrow-rs/pull/5543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correctly encode ticket [arrow-rs]
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on PR #5543:
URL: https://github.com/apache/arrow-rs/pull/5543#issuecomment-2018058366
> Thank you @freddieptf
>
> I wonder if there is any test we can write to make sure we don't break the feature in the future 🤔
I would think we could create a flight client/server round trip test. It wouldn't ensure we hadn't broken JDBC compatibility, but it would ensure the client and server can talk.
For JDBC compatibility we would have to do some integration testing like they have in the arrow repo running the combinatorics matrix of tests - perhaps that is where the JDBC compatibility test should live.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org