You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/02 13:29:28 UTC

[GitHub] [cloudstack] SadiJr opened a new pull request, #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

SadiJr opened a new pull request, #6943:
URL: https://github.com/apache/cloudstack/pull/6943

   PR #5774 introduced a functionality to allow operators to choose in which Veeam's repository, if more than one is configured, ACS' clone job will be executed. However, a change was missing in the PR and caused the errors reported in #6599. 
   
   This PR addresses the fix for #6599.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   ![205299189-cb62a8c6-9a75-4086-a77e-b7842fd0ce75](https://user-images.githubusercontent.com/31869303/205303051-1b1df656-acb7-451d-bb56-a1a73e0d1dda.png)
   
   ### How Has This Been Tested?
   
   It was tested in a local laboratory:  
   - I assigned three VMs to three Backup Offerings;
   - Before, the assign fails, with the same message reported in issue #6599;
   - Now the assign works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1343851448

   <b>Trillian test result (tid-5430)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45345 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5430-vmware-65u2.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1339510842

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1340317482

   <b>Trillian test result (tid-5401)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42972 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5401-xenserver-71.zip
   Smoke tests completed. 96 look OK, 3 have errors, 6 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_verify_ipv6_network | `Error` | 106.76 | test_network_ipv6.py
   test_01_verify_ipv6_network | `Error` | 106.77 | test_network_ipv6.py
   ContextSuite context=TestIpv6Network>:teardown | `Error` | 109.77 | test_network_ipv6.py
   test_01_create_ipv6_guest_prefix | `Error` | 0.04 | test_ipv6_infra.py
   test_01_create_ipv6_public_ip_range | `Error` | 0.03 | test_ipv6_infra.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 614.01 | test_kubernetes_clusters.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
   all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_nic | `Skipped` | --- | test_nic.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1336484255

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1339386398

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1340314400

   <b>Trillian test result (tid-5403)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42777 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5403-vmware-65u2.zip
   Smoke tests completed. 99 look OK, 0 have errors, 6 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
   all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1343785032

   <b>Trillian test result (tid-5432)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38428 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5432-xenserver-71.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1339511952

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1335297554

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6943](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e6ca61) into [main](https://codecov.io/gh/apache/cloudstack/commit/3d8ea4f3b3ee1c009871e00d20ea03087cdc18a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d8ea4f) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #6943   +/-   ##
   =========================================
     Coverage     10.87%   10.88%           
   - Complexity     7118     7121    +3     
   =========================================
     Files          2485     2485           
     Lines        245522   245522           
     Branches      38335    38335           
   =========================================
   + Hits          26701    26714   +13     
   + Misses       215550   215536   -14     
   - Partials       3271     3272    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/cloudstack/backup/veeam/VeeamClient.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvdmVlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL3ZlZWFtL1ZlZWFtQ2xpZW50LmphdmE=) | `16.40% <ø> (ø)` | |
   | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
   | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1335338011

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6943)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1340336359

   <b>Trillian test result (tid-5402)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45109 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5402-kvm-centos7.zip
   Smoke tests completed. 96 look OK, 8 have errors, 1 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_verify_ipv6_network | `Failure` | 205.72 | test_network_ipv6.py
   test_01_verify_ipv6_network | `Error` | 205.72 | test_network_ipv6.py
   ContextSuite context=TestIpv6Network>:teardown | `Error` | 208.73 | test_network_ipv6.py
   ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
   test_deploy_vm_from_iso | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
   test_deploy_more_vms_than_limit_allows | `Error` | 0.00 | test_deploy_vms_in_parallel.py
   test_01_create_ipv6_guest_prefix | `Error` | 0.04 | test_ipv6_infra.py
   test_01_create_ipv6_public_ip_range | `Error` | 0.03 | test_ipv6_infra.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 605.20 | test_kubernetes_clusters.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6943:
URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1343855719

   <b>Trillian test result (tid-5431)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45516 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6943-t5431-kvm-centos7.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Error` | 3947.01 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 92.75 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org