[jira] [Comment Edited] (IGNITE-12108) [IEP-35] Migrate Communication Metrics.

["Nikolay Izhikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962894#comment-16962894 ] 

Nikolay Izhikov edited comment on IGNITE-12108 at 10/30/19 10:13 AM:
---------------------------------------------------------------------

[~ibessonov]

First of all, thanks for working on this.

> One of those constructors (GridNioServer) already had nullable parameter, should I eliminate it as well? 

Yes. I think we should do it.

As I can see, there is only one place in the source, where we pass null as {MetricRegistry}
{code:java}
    public GridTcpNioCommunicationClient(
        int connIdx,
        GridNioSession ses,
        IgniteLogger log
    ) {
        super(connIdx, null);

        assert ses != null;
        assert log != null;

        this.ses = ses;
        this.log = log;
    }
{code}

It's not clear for me, why we do it.
We can do one of following improvements:

1. Provide corresponding {{MetricRegistry}} in { {GridTcpNioCommunicationClient}} and collect metrics for it.
2. Eliminate {{MetricRegistry}} from {{GridAbstractCommunicationClient}} and store it directly in {{GridShmemCommunicationClient}} - only usage of it.

>  I'll commit that changes soon.

I think we should come to a consensus here before the merge.


was (Author: nizhikov):
[~ibessonov]

First of all, thanks for working on this.

> One of those constructors (GridNioServer) already had nullable parameter, should I eliminate it as well? 

Yes. I think we should do it.

As I can see, there is only one place in the source, where we pass null as {MetricRegistry}
{code:java}
    public GridTcpNioCommunicationClient(
        int connIdx,
        GridNioSession ses,
        IgniteLogger log
    ) {
        super(connIdx, null);

        assert ses != null;
        assert log != null;

        this.ses = ses;
        this.log = log;
    }
{code}

It's not clear for me, why we do it.
We can do one of following improvements:

1. Provide corresponding {MetricRegistry} in  {GridTcpNioCommunicationClient} and collect metrics for it.
2. Eliminate {MetricRegistry} from {GridAbstractCommunicationClient} and store it directly in {GridShmemCommunicationClient} - only usage of it.

>  I'll commit that changes soon.

I think we should come to a consensus here before the merge.

> [IEP-35] Migrate Communication Metrics.
> ---------------------------------------
>
>                 Key: IGNITE-12108
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12108
>             Project: Ignite
>          Issue Type: New Feature
>            Reporter: Ivan Bessonov
>            Assignee: Ivan Bessonov
>            Priority: Major
>              Labels: IEP-35, await
>             Fix For: 2.8
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> ||*Name*||*Description*||
> |communication.tcp.outboundMessagesQueueSize|Number of messages waiting to be sent|
> |communication.tcp.sentBytes|Total number of bytes received by current node|
> |communication.tcp.receivedBytes|Total number of bytes sent by current node|
> |communication.tcp.sentMessagesCount|Total number of messages sent by current node|
> |communication.tcp.receivedMessagesCount|Total number of messages received by current node|
> |communication.tcp.sentMessagesByType.<directType>|Total number of messages with given type sent by current node|
> |communication.tcp.receivedMessagesByType.<directType>|Total number of messages with given type received by current node|
> |communication.tcp.<nodeId>.sentMessagesToNode|Total number of messages sent by current node to the given node|
> |communication.tcp.<nodeId>.receivedMessagesFromNode|Total number of messages received by current node from the given node|
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)