[GitHub] [airflow] dwreeves commented on a diff in pull request #28582: Amazon Provider Package release 7.0.0 - Add description of breaking changes

[GitBox <gi...@apache.org>]

dwreeves commented on code in PR #28582:
URL: https://github.com/apache/airflow/pull/28582#discussion_r1057302238


##########
airflow/providers/amazon/CHANGELOG.rst:
##########
@@ -46,6 +47,7 @@ Features
 * ``Use Boto waiters instead of customer _await_status method for RDS Operators (#27410)``
 * ``Handle transient state errors in 'RedshiftResumeClusterOperator' and 'RedshiftPauseClusterOperator' (#27276)``
 * ``Add retry option in RedshiftDeleteClusterOperator to retry when an operation is running in the cluster (#27820)``
+* ``Deprecate 'full_url_mode' for SecretsManagerBackend; whether a secret is a JSON or URL is inferred (#27920)``

Review Comment:
   The `full_url_mode` kwarg is deprecated, but not removed (in the sense that it won't return an error).
   
   https://github.com/apache/airflow/blob/68acca53f4c9b91cdaae9af02234da15a9a735dd/airflow/providers/amazon/aws/secrets/secrets_manager.py#L125
   
   There is basically zero harm in removing it, since anyone who is using all URLs will not be disrupted by its removal under normal circumstances (their secrets will continue to parse normally), and also anyone who is using all JSONs will not be disrupted (their secrets will also continue to parse normally).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org