[GitHub] [incubator-superset] villebro commented on a change in pull request #7795: add an option to export csv file with verbose column names

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #7795: add an option to export csv file with verbose column names
URL: https://github.com/apache/incubator-superset/pull/7795#discussion_r301403230
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -491,6 +491,10 @@ def data(self):
     def get_csv(self):
         df = self.get_df()
         include_index = not isinstance(df.index, pd.RangeIndex)
+        if config.get("CSV_EXPORT_VERBOSE") == True:
 
 Review comment:
   This tripped `flake8`, can be expressed
   ```python
   if config.get("CSV_EXPORT_VERBOSE"):
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org