You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/01/05 22:20:35 UTC

[PR] Minor: Fix flake in newly added dictionary.slt test [arrow-datafusion]

alamb opened a new pull request, #8769:
URL: https://github.com/apache/arrow-datafusion/pull/8769

   ## Which issue does this PR close?
   
   Related to https://github.com/apache/arrow-datafusion/pull/8750 
   
   ## Rationale for this change
   
   I added new tests in https://github.com/apache/arrow-datafusion/pull/8750 
   
   I noticed this test failed on main on one CI job and then passes on the next
   
   Here is an example failure https://github.com/apache/arrow-datafusion/actions/runs/7426719857/job/20211097126
   
   ## What changes are included in this PR?
   
   Add `rowsort` to the output of a query without an order by to keep it consistent
   
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Minor: Fix flake in newly added dictionary.slt test [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #8769: Minor: Fix flake in newly added dictionary.slt test
URL: https://github.com/apache/arrow-datafusion/pull/8769


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org